[RS-2297] Run dashboard-installer on operator update
#3759
Conversation
| @@ -8,7 +8,7 @@ | |||
| "spec": { | |||
| "order": 1, | |||
| "tier": "allow-tigera", | |||
| "selector": "job-name == 'dashboards-installer'", | |||
| "selector": "job-name contains 'dashboards-installer'", | |||
There was a problem hiding this comment.
I think we should be using a different selector rather than the "contains" operator here. There's no reason we need to use the job-name label AFAIK - we could have role: dashboard-installer applied regardless of the actual name, for example.
My concern is just that contains is a pretty unusual operation, and given there's no concrete need for it here it makes this policy less intuitive.
| @@ -49,6 +50,18 @@ var ( | |||
| PolicyName = networkpolicy.TigeraComponentPolicyPrefix + Name | |||
| ) | |||
|
|
|||
| // GetJobName makes a unique job name per operator version. | |||
| // For dev images it takes the first 32 chars. | |||
| func GetJobName() string { | |||
There was a problem hiding this comment.
If we're switching to this, we should stop exporting the Name variable so that nobody accidentally uses the wrong value.
There was a problem hiding this comment.
If Name isn't actually used except for within this function, we should probably just scope it to this function to be extra sure (i.e., remove the package level variable)
| func GetJobName() string { | ||
| operatorVersion := strings.ReplaceAll(version.VERSION, ".", "-") | ||
|
|
||
| if len(operatorVersion) >= 32 { |
There was a problem hiding this comment.
What is "32" in this context? Why do we need to truncate? I think we should have a comment explaining why we do this - it's not obvious!
There was a problem hiding this comment.
I think without truncation the job name ended up being 80+ characters and I think Job names are limited to 63.
Good idea to explain in a comment.
Maybe I can also include an example in the comment, for example:
v1.36.10-1.dev-281-g9558bdac82be-2025-01-28-master-treachery is truncated to be v1.36.10-1.dev-281-g9558bdac82be
There was a problem hiding this comment.
I thought changing the job would mean that the operator would delete the job object and recreate it, resulting in a new run. Am I missing something?
See
operator/pkg/controller/utils/component.go
Line 167 in f4b6cf4
I think we should find out why that logic was not sufficient in re-running the job instead.
|
Closing. Opening: #3768 instead |
Description
https://tigera.atlassian.net/browse/RS-2297 - Honeypods dashboard remains in Kibana on upgrade from
v3.19dashboard-installerJob runs so that new Kibana dashboards are installed and deprecated ones are removed. Works in combination with https://github.com/tigera/calico-private/pull/8613For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.